Attention is currently required from: Paul Menzel, Mario Scheithauer.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69972 )
Change subject: mb/siemens/mc_ehl2: Disable GSPI2 controller
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69972/comment/61d23e5d_523b7778
PS2, Line 145: device pci 12.0 on end # GSPI2
Why is setting it to `off` not enough, so it’s clear it could theoretically be enabled?
looks like elkhartlake doesn't have a chipset devicetree that disables all non-essential devices by default. when coreboot complains that there's a leftover static device that means that the device wasn't discovered when scanning the bus, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69972
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7462312953d50385ca7bb2f2e0abb8fc3a5886
Gerrit-Change-Number: 69972
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Fri, 25 Nov 2022 15:51:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment
