30 May
2019
30 May
'19
2:36 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32585 )
Change subject: mb/lenovo/*: Add support for VBOOT on 8MiB devices ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32585/6/src/mainboard/lenovo/x220/Kconfig File src/mainboard/lenovo/x220/Kconfig:
https://review.coreboot.org/#/c/32585/6/src/mainboard/lenovo/x220/Kconfig@56 PS6, Line 56: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" Why is this file needed? It breaks things that would otherwise be added to the default fmd (e.g. flash console). How is this related to vboot?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb7b263ed86551cc53e1db7babccaca6b3ae2fe6
Gerrit-Change-Number: 32585
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 May 2019 23:36:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment