[coreboot-gerrit] Change in ...coreboot[master]: acpi: Add SPMI table

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33487 )

Change subject: acpi: Add SPMI table
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/33487/2/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/#/c/33487/2/src/arch/x86/acpi.c@793 
PS2, Line 793: 	header->length = sizeof(struct acpi_spmi);
> is it needed to do this twice? I don;t see why the value should change between this line and line 82 […]

Done

https://review.coreboot.org/#/c/33487/2/src/arch/x86/include/arch/acpi.h 
File src/arch/x86/include/arch/acpi.h:

https://review.coreboot.org/#/c/33487/2/src/arch/x86/include/arch/acpi.h@786 
PS2, Line 786: 	IPMI_INTERFACE_RESERVED,
> maybe add an explicit = 0 here, so that it is more obvious that this will get used as raw values

Done