Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: Support more DRAM frequency bootup
......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr...
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr...
PS13, Line 1600: dqsdly_byte[byte] = (dqsdly_byte[byte] > 0) ? 0 : -dqsdly_byte[byte];
Done
Ack
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr...
PS13, Line 1895: best_coarse_tune2t[rank][dqs] = (dqsg0 >> (dqs * 8)) & 0x7;
Done
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1378ca43fb333c445ca77e7dc0844cdf65f2207
Gerrit-Change-Number: 34332
Gerrit-PatchSet: 22
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Aug 2019 08:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-MessageType: comment