Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45373 )
Change subject: soc/intel/common/block: Do not die if PRMRR size unsupported ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
When EnableC6Dram=1 and the user selects an unsupported PRMRR size, the device will brick in runtime. I'm not sure if that is any better.
This turned out to be wrong, since fsp sets PRMRR right, when EnableC6Dram=1
https://review.coreboot.org/c/coreboot/+/45373/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45373/1/src/soc/intel/common/block/... PS1, Line 373: BIOS_WARNING
I wonder if there is any device where we currently hit that die(). […]
thinking about this again, just printing a warning or an error is ok, since the prmrr will result in size=0 then; so, ignore my second comment here