[coreboot-gerrit] Change in coreboot[master]: vboot: push clear recovery mode switch until BS_WRITE_TABLES

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38779 )

Change subject: vboot: push clear recovery mode switch until BS_WRITE_TABLES
......................................................................

Patch Set 3:

This patch is now failing due to compiling with CHROMEOS and EC_GOOGLE_CHROMEEC, but not EC_GOOGLE_CHROMEEC_SWITCHES.

Should the last two be interdependent?  Or should google_chromeec_add_recovery_event() move into ec/google/chromeec/switches.c?

When I try that, I get an error about BOOT_STATE_INIT_ENTRY not working properly:

src/ec/google/chromeec/switches.c:89:49: error: expected ')' before '(' token
         google_chromeec_elog_add_recovery_event, NULL);
                                                 ^
                                                 )
    CC         romstage/lib/gpio.o
src/ec/google/chromeec/switches.c:60:13: error: 'google_chromeec_elog_add_recovery_event' defined but not used [-Werror=unused-function]
 static void google_chromeec_elog_add_recovery_event(void *unused)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Why can't BOOT_STATE_INIT_ENTRY be used in this file?  For reference, switches.c is included via:

verstage-$(CONFIG_EC_GOOGLE_CHROMEEC_SWITCHES) += switches.c
romstage-$(CONFIG_EC_GOOGLE_CHROMEEC_SWITCHES) += switches.c
ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_SWITCHES) += switches.c