build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28104 )
Change subject: lib/fit_payload: Add coreboot tables support for FDT.
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/28104/10/src/lib/fit_payload.c
File src/lib/fit_payload.c:
https://review.coreboot.org/#/c/28104/10/src/lib/fit_payload.c@111
PS10, Line 111: static const char *firmware_path[] = {"firmware", NULL};
static const char * array should probably be static const char * const
https://review.coreboot.org/#/c/28104/10/src/lib/fit_payload.c@118
PS10, Line 118: static const char *coreboot_path[] = {"coreboot", NULL};
static const char * array should probably be static const char * const
--
To view, visit
https://review.coreboot.org/28104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977
Gerrit-Change-Number: 28104
Gerrit-PatchSet: 10
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Aug 2018 06:57:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No