Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31371 )
Change subject: soc/intel/apl: enable lpc at bootblock ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31371/2/src/soc/intel/apollolake/chip.h File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/#/c/31371/2/src/soc/intel/apollolake/chip.h@48 PS2, Line 48: 4 shouldn't this be based on the expected size? i.e. LPC_NUM_GENERIC_IO_RANGES ?