Attention is currently required from: Shelley Chen, Furquan Shaikh, Prasad Malisetty. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58683 )
Change subject: DO NOT SUBMIT: Proposed libpayload changes for PCI mmio ops support ......................................................................
Patch Set 3:
(4 comments)
File payloads/libpayload/drivers/pci_ops.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131914): https://review.coreboot.org/c/coreboot/+/58683/comment/6ab7d72c_d150bb58 PS3, Line 31: pcidev_t * dev) "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131914): https://review.coreboot.org/c/coreboot/+/58683/comment/bf5739b6_598f3440 PS3, Line 75: int pci_find_device(u16 vid, u16 did, pcidev_t * dev) "foo * bar" should be "foo *bar"
File src/lib/coreboot_table.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131914): https://review.coreboot.org/c/coreboot/+/58683/comment/979929c4_d8a76405 PS3, Line 502: (CONFIG_MMIO_LENGTH > 0)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131914): https://review.coreboot.org/c/coreboot/+/58683/comment/5b2a13ee_4f0197d1 PS3, Line 502: (CONFIG_MMIO_LENGTH > 0)) please, no spaces at the start of a line