[coreboot-gerrit] [M] Change in coreboot[main]: vendorcode/amd/opensil/genoa: Implement console callback

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Varshit Pandya.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76512?usp=email )

Change subject: vendorcode/amd/opensil/genoa: Implement console callback
......................................................................

Patch Set 11:

(3 comments)

File src/vendorcode/amd/opensil/genoa_poc/opensil_console.c:

https://review.coreboot.org/c/coreboot/+/76512/comment/d4542e01_7b14d71e :
PS10, Line 34: 	char prefix[60];
             : 	snprintf(prefix, sizeof(prefix), "%s%s:%d:", SilPrefix, (uintptr_t)Function, Line);
> this doesn't need to be formatted to a buffer and we can use printk directly here

Done

https://review.coreboot.org/c/coreboot/+/76512/comment/a467056d_5b336e9d :
PS10, Line 35: %d
> %zu

Done

https://review.coreboot.org/c/coreboot/+/76512/comment/ca95bd02_34e96d22 :
PS10, Line 35: (uintptr_t)
> this cast looks wrong

Done