Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47380 )
Change subject: mb/google/kukui: Add panel api after dsi start
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/...
PS4, Line 11: #define ANX7625_I2C_BUS 4
please add a blank line between #include, #define and function blocks, e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/...
PS4, Line 47: i2c_bus
Simply "ANX7625_I2C_BUS" and remove the local variable.
Will fix next version
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/...
PS4, Line 62: u8
const u8
I'll remove this line.
Use ANX7625_I2C_BUS,
Ex, anx7625_init(ANX7625_I2C_BUS)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bded27087490f32ee233e615cfad1fd05fb582d
Gerrit-Change-Number: 47380
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-CC: Will Lee
wwlee@google.com
Gerrit-Comment-Date: Wed, 30 Dec 2020 11:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment