[coreboot-gerrit] [S] Change in coreboot[main]: acpi/acpi_gic: Add GIC ITS subtable

[Naresh Solanki (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, Lance Zhao, Maximilian Brune, Nico Huber, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78115?usp=email )

Change subject: acpi/acpi_gic: Add GIC ITS subtable
......................................................................

Patch Set 4:

(3 comments)

File src/acpi/acpi_gic.c:

https://review.coreboot.org/c/coreboot/+/78115/comment/e864eea9_c98ca03b :
PS4, Line 85: }
> > Is this weak implementation necessary? The other platform_*() functions […]

Weak was added to address situation wherein GIC ITS subtable isn't needed when generating GIC table.

Overall all GIC specific info being in devicetree would be better approach.

https://review.coreboot.org/c/coreboot/+/78115/comment/05b0f551_d5f157a2 :
PS4, Line 99: its_base + (i * its_size);
> This API is strange and possibly not sufficiently generic. […]

Acknowledged

File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/78115/comment/1c4da3ff_a734100b :
PS4, Line 1600: uintptr_t
> size_t

Acknowledged