Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80369?usp=email )
Change subject: drivers/qemu/fw_cfg: Support architectures using MMIO ......................................................................
Patch Set 1:
(2 comments)
File src/drivers/emulation/qemu/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/80369/comment/3ea37cfa_f6d893ac : PS1, Line 61: else { When using braces, they should be on all paths, i.e. the if() part too.
https://review.coreboot.org/c/coreboot/+/80369/comment/066f2a69_6520ead4 : PS1, Line 62: #if CONFIG(CPU_QEMU_X86) Regular C `if ()` is much preferred. I know this isn't straight forward here because of the missing declarations. Though, maybe a single #if block above would be nicer, e.g. ``` #if !CONFIG(CPU_QEMU_X86) unsigned char inb(int); void outb(unsigned char, int); ... #endif ``` Then the compiler shouldn't complain and the linker drop the dead paths.