Attention is currently required from: Alper Nebi Yasak.
2 comments:
File src/drivers/emulation/qemu/fw_cfg.c:
Patch Set #1, Line 61: else {
When using braces, they should be on all paths, i.e. the if() part too.
Patch Set #1, Line 62: #if CONFIG(CPU_QEMU_X86)
Regular C `if ()` is much preferred. I know this isn't straight forward here
because of the missing declarations. Though, maybe a single #if block above
would be nicer, e.g.
```
#if !CONFIG(CPU_QEMU_X86)
unsigned char inb(int);
void outb(unsigned char, int);
...
#endif
```
Then the compiler shouldn't complain and the linker drop the dead paths.
To view, visit change 80369. To unsubscribe, or for help writing mail filters, visit settings.