Attention is currently required from: Felix Singer, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, Aaron Durbin. Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58019
to look at the new patch set (#20).
Change subject: soc/intel: move disabling of PM Timer to SoC PMC code ......................................................................
soc/intel: move disabling of PM Timer to SoC PMC code
Move disabling of PM Timer to SoC PMC code.
The original reason for placing that in `finalize` [1] was FSP hanging due to use of the PM timer without enabling timer emulation first in coreboot, which was added later [2].
[1] commit 6c1bf27dae (intel/skylake: disable ACPI PM Timer to enable XTAL OSC shutdown)
[2] commit f004f66ca7 (soc/intel/skylake: Enable ACPI PM timer emulation on all CPUs)
Change-Id: I354c3aea0c8c1f8ff3d698e0636932b7b76125f7 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/soc/intel/alderlake/finalize.c M src/soc/intel/alderlake/pmc.c M src/soc/intel/elkhartlake/finalize.c M src/soc/intel/elkhartlake/pmc.c M src/soc/intel/icelake/finalize.c M src/soc/intel/icelake/pmc.c M src/soc/intel/jasperlake/finalize.c M src/soc/intel/jasperlake/pmc.c M src/soc/intel/tigerlake/finalize.c M src/soc/intel/tigerlake/pmc.c 10 files changed, 45 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/58019/20