Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: mb/protectli/vault_kbl: Add FW6 support ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
I see there aren't any thermal zones set up for IT8772 fan control, how are you handling that?
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... File Documentation/mainboard/protectli/fw6.md:
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro... PS8, Line 38: The first supported missing rest of sentence
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau... PS8, Line 5: select BOARD_ROMSIZE_KB_8192 : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select SOC_INTEL_KABYLAKE : select SUPERIO_ITE_IT8772F : select MAINBOARD_HAS_LIBGFXINIT : select SEABIOS_ADD_SERCON_PORT_FILE if PAYLOAD_SEABIOS : select SPI_FLASH_MACRONIX alphabetize?