Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33361 )
Change subject: soc/intel/block/cpu: Add a MP init choice selection ......................................................................
Patch Set 2:
(3 comments)
As we already have the original, selectable Kconfig options, we could make the choice items depend on them (see inline comments). Might look a little con- fusing, but works: Just checked saddlebrook and icl rvp menus. Saddlebrook is limited to FSP MP init as selected and icl rvp shows all options with PPI default.
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 60: bool "Perform MP Initialization by coreboot" depends on !USE_INTEL_FSP_MP_INIT && !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 64: select USE_INTEL_FSP_MP_INIT depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 67: bool "Perform MP Initialization by FSP using coreboot MP PPI service" depends on !USE_INTEL_FSP_MP_INIT