Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44854 )
Change subject: mb/google/poppy/var/rammus: Update SPD table for Rammus
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44854/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44854/8//COMMIT_MSG@11
PS8, Line 11: SPD_SOURCES += samsung_dimm_K4E8E324ED-EGCG # 0b0110
: SPD_SOURCES += samsung_dimm_K4E6E304ED-EGCG # 0b0111
Please add space to align with 'Add ...'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82386507c4e996e0a59c26ce50de3bced45b1196
Gerrit-Change-Number: 44854
Gerrit-PatchSet: 8
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Sep 2020 06:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment