Attention is currently required from: Anson Tseng, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/volteer/variants/delbin/variant.c:
https://review.coreboot.org/c/coreboot/+/59557/comment/9c90aeb9_ddc0a336 PS6, Line 7: : extern struct chip_operations drivers_i2c_generic_ops; : static void audio_codec_update(void) : { : const struct device_path codec_path[] = { : {.type = DEVICE_PATH_PCI, .pci.devfn = PCH_DEVFN_I2C0}, : {.type = DEVICE_PATH_I2C, .i2c.device = 0x1a} : }; : const struct device *codec = : find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); : struct drivers_i2c_generic_config *config; : : if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info) : return; : config = codec->chip_info; : : if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) : config->hid = "10EC5682"; : else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS))) : config->hid = "RTL5682";
if you add the alias above, you should be able to simplify this to (untested): […]
look like lack DEV_PTR define in volteer FW branch ./src/third_party/coreboot/src/include/device/device.h #define DEV_PTR(_alias)