HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )
Change subject: mb/asus/p5ql-em: Add mainboard ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5qc/rom... File src/mainboard/asus/p5qc/romstage.c:
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5qc/rom... PS6, Line 26: northbridge/intel/x4x/iomap.h> maybe not needed
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5ql-em/... PS6, Line 14: stdint.h looks like it is not used
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/cstates.c:
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5ql-em/... PS6, Line 15: #include <device/device.h> : #include <southbridge/intel/i82801jx/i82801jx.h> maybe not used
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/romstage.c:
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5ql-em/... PS6, Line 28: northbridge/intel/x4x/iomap.h remove?