build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )
Change subject: [WIP] soc/skl/vr_config: Add VR config for SKL-S/H/U ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35167/6/src/soc/intel/skylake/vr_co... File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35167/6/src/soc/intel/skylake/vr_co... PS6, Line 191: else if (tdp >= 25) { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/35167/6/src/soc/intel/skylake/vr_co... PS6, Line 216: case PCI_DEVICE_ID_INTEL_SKL_ID_H_2: /* fallthrough */ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/c/coreboot/+/35167/6/src/soc/intel/skylake/vr_co... PS6, Line 217: case PCI_DEVICE_ID_INTEL_SKL_ID_H_EM: /* fallthrough */ Possible switch case/default not preceded by break or fallthrough comment