Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28765 )
Change subject: amd/stoneyridge: Create gnvs entries for AOAC devices ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/acpi/globaln... File src/soc/amd/stoneyridge/acpi/globalnvs.asl:
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/acpi/globaln... PS1, Line 50: , 5, // 0x31 - AOAC Device Enables
Do we want to pad this to a dword boundary?
Same thoughts as in the other patch. Except for appearance, I don't think it would do much for us.
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 404: int
uint32_t?
Hmm, I seem to recall int is proper for declaring n:m but I could be wrong. I've seen some examples of unsigned on the interwebs.