Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30879 )
Change subject: sb/intel: Check for NULL-return of pcidev_on_root()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30879/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30879/1//COMMIT_MSG@10
PS1, Line 10: 0:2.0 may be disabled.
Maybe comment it removes some ACPI data when IGD is disabled? If it does so...
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bab8fa3a82daca71d03453315cdd69d8951fc24
Gerrit-Change-Number: 30879
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Jan 2019 14:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment