Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM) ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c... PS2, Line 1446: struct ec_response_usb_pd_control_v2 resp = {}; : struct chromeec_command cmd = { : .cmd_code = EC_CMD_USB_PD_CONTROL, : .cmd_version = 2, : .cmd_data_in = &pd_control, : .cmd_size_in = sizeof(pd_control), : .cmd_data_out = &resp, : .cmd_size_out = sizeof(resp), : .cmd_dev_index = 0, : }; :
this is currently being used in depthcharge as well so it should be stable
Ack
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c... PS2, Line 1460: PD_CC_DFP_ATTACHED
ACK. This above check is fine as it is to see if DFP or UFP is attached. […]
Ok, then maybe a comment would help explain this, because I read this as `true` for `bool ufp` means that the EC is an UFP (there is something attached downstream, regardless of what type it is), but it seems to mean that it's only a non-debug device attached.