30 Dec
2019
30 Dec
'19
12:28 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37946 )
Change subject: kontron/986lcd-m: use common winbond/nuvoton HWM bank select function ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37946/1/src/mainboard/kontron/986lc... File src/mainboard/kontron/986lcd-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/37946/1/src/mainboard/kontron/986lc... PS1, Line 11: select SUPERIO_NUVOTON_COMMON_HWM
I selected this in the mainboard's Kconfig file and not in the SIO's Kconfig file, since the SIO cod […]
I agree with Felix
--
To view, visit https://review.coreboot.org/c/coreboot/+/37946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I169b16c99a864ecff54112bcc073f2c141c2009f
Gerrit-Change-Number: 37946
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 29 Dec 2019 23:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: comment