[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Override uart base address via VPD variable

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )

Change subject: mb/ocp/deltalake: Override uart base address via VPD variable
......................................................................

Patch Set 14:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak... 
File src/mainboard/ocp/deltalake/romstage.c:

https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak... 
PS14, Line 49: default
get_uart_for_console should check the vpd setting and return the default if the value is out of range or there will could be an fsp and console mismatch. This can be a lookup like the uart code.

static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
base = bases[get_uart_for_console()];

https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak... 
File src/mainboard/ocp/deltalake/uartio_vpd.c:

https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak... 
PS14, Line 18: COREBOOT_UART_IO_DEFAULT
no need for the else, already set above.