Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40562 )
Change subject: security/vboot: Make vboot library is accessible to ramstage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40562/2/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40562/2/src/security/vboot/Makefile... PS2, Line 130: ramstage-y += vboot_logic.c vboot_logic.c was supposed to be the file where we only have the code that is really needed at verification time, and all random support routines that might be needed at other times as well were supposed to go elsewhere. I guess we already failed that by adding it to romstage, but would you mind fixing it now? I think you just need to move vboot_save_data() and vboot_save_nvdata_only() from vboot_logic.c into vboot_common.c (and then you should be able to remove the romstage-y += vboot_logic.c as well).