[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
PS3, Line 191: on
> if the bios deals with Touchpad devices (USB devices), it has to deal with thermal devices for sure. […]

For bootblock we use tempbar and that does end up adding device specific code to program the BARs. Also, typically it is done that way since there are very few devices which need to be accessed early on before device enumeration is done.

For ramstage, we already have common code to deal with resource allocation and so we do not need to carry device specific code every where to program temporary BARs and setup access. In my opinion, it makes sense to enable the right device in devicetree and let the resource allocator provide the required resources rather than having to calculate a BAR manually.