Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46977 )
Change subject: sb/intel/lynxpoint: Use common code to generate HPET table ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46977/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/46977/1/src/southbridge/intel/lynxp... PS1, Line 758: : printk(BIOS_DEBUG, "ACPI: * HPET\n"); : : hpet = (acpi_hpet_t *)current; : current += sizeof(acpi_hpet_t); : current = acpi_align_current(current); : acpi_create_hpet(hpet); : acpi_add_table(rsdp, hpet); why not use acpi_write_hpet?