Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40247 )
Change subject: soc/amd/common: Determine # of I2C controllers at runtime
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40247/1/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/1/src/soc/amd/picasso/i2c.c@3...
PS1, Line 30: "ARRAY_SIZE(i2c_bus_address) must equal I2C_DEVICE_COUNT");
Sure, but why?
https://review.coreboot.org/c/coreboot/+/40247/1/src/soc/amd/picasso/i2c.c@1...
PS1, Line 154: unsigned int index = i2c_start_index();
const?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I397b074ef9c14bf6a4f6680696582f5173a5d0d3
Gerrit-Change-Number: 40247
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Apr 2020 12:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment