Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 301: emi_mdl_init
emi_mdl_init() was implement and be called in this patch, I am not understand why need move to only […]
Because it will be easier to revert/reland patches, and easier to rename functions.
We're not asking you to move emi_mdl_init() implementation to CB:44699. Instead, we want to add emi_mdl_init() to dramc_pi_api.h in this patch.
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 374: 2
sorry, wrong link. […]
Still wrong link?