Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31488 )
Change subject: soc/amd/common: Identify AGESA call pattern ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 68: AGESA_STATUS
Some consistency with src/drivers. […]
Definitely not recoverable, as AGESA would not know what is required on a particular call. In some situations it might use the default, but in many cases it would hang inside AGESA, as AGESA's create struct adds the default actions when creating the structure (not latter), so AGESA would enter an internal loop. That said, consistency is a valid argument.