build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR ......................................................................
Patch Set 20:
(8 comments)
https://review.coreboot.org/#/c/29065/20/src/cpu/amd/family_10h-family_15h/d... File src/cpu/amd/family_10h-family_15h/defaults.h:
https://review.coreboot.org/#/c/29065/20/src/cpu/amd/family_10h-family_15h/d... PS20, Line 77: { NB_CFG_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC, line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/cpu/amd/family_10h-family_15h/d... PS20, Line 107: 1 << 21, 0x00000000 }, /* Erratum #254 DR B1 BU_CFG_MSR[21]=1 */ line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/cpu/amd/family_10h-family_15h/d... PS20, Line 118: { CPU_ID_FEATURES_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC, line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/include/cpu/amd/msr.h File src/include/cpu/amd/msr.h:
https://review.coreboot.org/#/c/29065/20/src/include/cpu/amd/msr.h@40 PS20, Line 40: #define PS_CTL_REG 0xC0010062 /* P-state Control Register */ line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/include/cpu/amd/msr.h@41 PS20, Line 41: #define PS_CMD_MASK_OFF 0xfffffff8 /* P-state Control Register CMD Mask OFF */ line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/include/cpu/amd/msr.h@43 PS20, Line 43: #define PS_MAX_REG 0xC0010068 /* Maximum P-State Register */ line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/include/cpu/amd/msr.h@44 PS20, Line 44: #define PS_MIN_REG 0xC0010064 /* Mimimum P-State Register */ line over 80 characters
https://review.coreboot.org/#/c/29065/20/src/northbridge/amd/amdmct/mct_ddr3... File src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c:
https://review.coreboot.org/#/c/29065/20/src/northbridge/amd/amdmct/mct_ddr3... PS20, Line 672: wrmsr(HWCR_MSR, msr); /* Setting wrap32dis allows 64-bit memory references in real mode */ line over 80 characters