[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Properly guard USB debug

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36878 )

Change subject: sb/intel/common: Properly guard USB debug
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36878/2/src/southbridge/intel/commo... 
File src/southbridge/intel/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/36878/2/src/southbridge/intel/commo... 
PS2, Line 31: bootblock-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_USB_DEBUG) += usb_debug.c
> please add ifeq ($(CONFIG_USBDEBUG),y) to reduce build time on all boards using SB_INTEL_COMMON

I wouldn't be surprised if more than half of the files here alone get GC depending on some other Kconfig symbol.
We build things that get GC all over coreboot.
The reason for not caring are:
- Things get build tested regardless of Kconfig
- The increase in build time is little since ccache is used.