Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )
Change subject: Add support for low power idle table ......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/32350/2/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32350/2/src/arch/x86/acpi.c@1139 PS2, Line 1139: lpit->lpit_native.residency_counter.space_id = 0x7F; : lpit->lpit_native.residency_counter.bit_width = 64; : lpit->lpit_native.residency_counter.bit_offset = 0; : lpit->lpit_native.residency_counter.access_size = 0; : lpit->lpit_native.residency_counter.addrl = 0x632; : lpit->lpit_native.residency_counter.addrh = 0; We need to move space_id and address in soc as those are soc specific. Will introduce soc specific call here to update those values.