Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38926 )
Change subject: Documentation: Add GM45 ThinkPads common page
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len...
File Documentation/mainboard/lenovo/xx00_series.md:
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len...
PS4, Line 1: T400
Yes. The only exception is R500. […]
That a device has a dGPU does not necessarily mean that the firmware descriptor changes. The GbE is more relevant.
https://review.coreboot.org/c/coreboot/+/38926/4/Documentation/mainboard/len...
PS4, Line 27: `util/bincfg`
Documented both methods.
Done, I think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85917821efe63fff4b933b6226e99c17b63eb1b9
Gerrit-Change-Number: 38926
Gerrit-PatchSet: 8
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 17 Feb 2020 13:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment