Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44739 )
Change subject: soc/intel/cnl: Allow enabling/disabling GNA device
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44739/13/src/soc/intel/cannonlake/f...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44739/13/src/soc/intel/cannonlake/f...
PS13, Line 529: GnaEnable
same as chap; do we want to have that in the devtree? I think the gna device is user-specific, iow gets enabled when the user needs it, not when the soc just supports it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I921e29bfc77c8096519b52fec8bb6b2193006f99
Gerrit-Change-Number: 44739
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 08:54:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment