Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37069 )
Change subject: trogdor: add support for Bubs variant ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 36: default 0x5
Looks like this needs to be 0x0 for Trogdor now.
edit: 0x6 (see below)
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 40: default 0xa
Sorry: 0x6, not 0x8. I only just now realized that SC7180 has fewer QUPs per WRAP than SDM845 had.
Sorry again, our schematics are basically loose unlabeled sheets of paper flying around the office and if you happen to pick up the wrong one you get outdated info. -.- I have now been informed that the correct EC bus is 0x0 (and TPM is 0x6).