Attention is currently required from: Jes Klinke, Christian Walter, Julius Werner.
Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Accept Google Ti50 TPM DID:VID
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/c37f9e87_a0b6187e
PS3, Line 67: if (version->type != GSC_CR50)
should we have a `printk` info here like down below in the function?
https://review.coreboot.org/c/coreboot/+/63158/comment/bab9b662_ea62c965
PS3, Line 214: ver->minor = 42;
why 42? if this is a placeholder, then we should have a TODO comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986
Gerrit-Change-Number: 63158
Gerrit-PatchSet: 3
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jett Rink
jettrink@chromium.org
Gerrit-CC: Jett Rink
jettrink@google.com
Gerrit-Attention: Jes Klinke
jbk@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 30 Mar 2022 19:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment