Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33273 )
Change subject: ifdtool: Enable GbE/PDR region access if they exist ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33273/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/#/c/33273/2/util/ifdtool/ifdtool.c@989 PS2, Line 989: rw_gbe
Should we have this check for all masters? Also, is this check required for EC region too?
Most of the masters are not very flexible like the BIOS one is.
I could do it for EC region as well, I intended to do PDR only until I saw the comment about GbE at the top of the function. But probably the EC region wasn't in here when that was written or it would have said EC as well...