Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44880 )
Change subject: security/intel/txt: Improve MTRR setup for GETSEC[ENTERACCS]
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44880/15/src/security/intel/txt/get...
File src/security/intel/txt/getsec_enteraccs.S:
https://review.coreboot.org/c/coreboot/+/44880/15/src/security/intel/txt/get...
PS15, Line 111: Disable all MTRRs
FYI that on DeltaLake, coreboot sets default memory attribute as WB instead of UC, through MSR 0x2ff.
Right. This code modifies the default memory attribute without restoring it. This is fixed in https://review.coreboot.org/c/coreboot/+/46375 (now merged)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d411f6450928357544be20250262c2005d1e75d
Gerrit-Change-Number: 44880
Gerrit-PatchSet: 15
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 08:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment