Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/19621 )
Change subject: mb/google/poppy:[WIP] Add MIPI camera support. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19621/1/src/mainboard/google/poppy/acpi/came... File src/mainboard/google/poppy/acpi/camera.asl:
PS1, Line 129: Sleep(3)
@Raj, having delays/sleep in ASL code, is that a good idea? Besides, how is
Since this is related to power sequencing of the sensors and vcm (that involve powering up/down voltage rails), which inherently require delays in stabilizing its output, this is needed. These values are arrived based on the specs and the optimal values found during validation.