Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32485 )
Change subject: soc/intel/common: Add new PAD_CFG macro. ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i... PS1, Line 248: PAD_CFG_GPI_GPIO_DRIVER_SCI Let's move this down along with PAD_CFG_GPI_IRQ_WAKE under SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i... PS1, Line 251: extra tab?
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i... PS1, Line 401: PAD_CFG_GPI_IRQ_WAKE It would be good to rename this to PAD_CFG_GPI_APIC_SCI() to make it clear what it is being configured for. You will also have to update mainboards using this. Probably can do that as a separate CL from PAD_CFG_GPI_GPIO_DRIVER_SCI.
https://review.coreboot.org/#/c/32485/1/src/soc/intel/common/block/include/i... PS1, Line 402: PAD_CFG_GPI_DUAL_ROUTE While we are here, we should also get rid of SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT and just copy its definition to PAD_CFG_GPI_IRQ_WAKE.