Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32663 )
Change subject: src/amd/stoneyridge: Move alink source to common
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32663/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32663/4//COMMIT_MSG@11
PS4, Line 11: however more modern APUs define only ABCFG in
: the BKDGs.
How do you ensure that common code does not end up accessing register spaces which are not defined?
https://review.coreboot.org/#/c/32663/4/src/soc/amd/common/block/include/amd...
File src/soc/amd/common/block/include/amdblocks/alink.h:
https://review.coreboot.org/#/c/32663/4/src/soc/amd/common/block/include/amd...
PS4, Line 22: +
nit: space around +.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c558ccc64bd04a66399c678d43beb0a97e72f63
Gerrit-Change-Number: 32663
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 May 2019 00:02:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment