Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34624 )
Change subject: soc/intel/cannonlake/bootblock: Clear the GPI IS & IE registers
......................................................................
Patch Set 3:
what is the real problem statement here?
GPI Interrupt Enable (GPI_INT_EN_GPPC_A_0): This bit is
used to enable/disable the generation of APIC interrupt when the
corresponding GPI_INT_STS bit is set.
0 = disable interrupt generation
1 = enable interrupt generation
i don't think if this bit remain set alone won't cause any issue unless GPI_INT_STS bit is also set at that time?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2185355d0095601e0778b6bf47ae137cc53e4051
Gerrit-Change-Number: 34624
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Jul 2019 05:58:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment