Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32188 )
Change subject: WIP: Power resource stub
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32188/1/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/#/c/32188/1/util/sconfig/main.c@514
PS1, Line 514: /* probed? */
Please explain in more detail why status==2 gets treated specially, rather than extracting bits from the value as happens in the 'else' clause.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I253a11e24a086792e151c3e47335586d43c3fce0
Gerrit-Change-Number: 32188
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Apr 2019 21:12:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment