Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48355 )
Change subject: device/azalia_device.c: Add codec reset helpers
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48355/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48355/3//COMMIT_MSG@9
PS3, Line 9: Many uses of `azalia_set_bits` are used to toggle the reset bit. They
: will be put to use in subsequent commits, one change per function.
:
Sorry, I don't understand what exactly is wrong with this commit message […]
I'm not sure how to parse it either. "They" in the last sentence seems
to be referring to the helpers. But when reading the sentence, one automa-
tically assumes it refers to the subject of the first sentence of the
paragraph, and fails. It seems one has to shuffle all three sentences
around until it makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0594fdaf99319f08a2e272cd37958f0f216e654
Gerrit-Change-Number: 48355
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Dec 2020 22:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment