Jim Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69929 )
Change subject: drivers/intel/mipi_camera: Remove IPU ES support entry for RPL ......................................................................
drivers/intel/mipi_camera: Remove IPU ES support entry for RPL
The current IPU ES entry value is always set to true for RPL and kernel picks the ES version of the main IPU FW even for the production bootloader but loading is not successful due to the authentication failure.
On Raptor Lake silicon, the production binaries are backward compatible with ES parts. This change removes the IPU ES support ACPI entry since the kernel needs to load the production IPU main firmware on both the ES/QS parts.
BUG=b:258125833 TEST=Verify the Camera functionality by enabling the IPU secure mode on RPL variants with both ES/QS silicon.
Signed-off-by: Jim Lai jim.lai@intel.com Change-Id: I9fd8ea0dd6ffdb16961bb017ba4388bf99e4d5bc --- M src/drivers/intel/mipi_camera/camera.c 1 file changed, 26 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/69929/1
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 5b69c01..ec89971 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -138,9 +138,7 @@ port_name[i] = strdup(name); if (CONFIG(ACPI_ADL_IPU_ES_SUPPORT)) { u32 cpu_id = cpu_get_cpuid(); - if (cpu_id == CPUID_ALDERLAKE_J0 || cpu_id == CPUID_ALDERLAKE_Q0 || - cpu_id == CPUID_RAPTORLAKE_P_J0 || - cpu_id == CPUID_RAPTORLAKE_P_Q0) + if (cpu_id == CPUID_ALDERLAKE_J0 || cpu_id == CPUID_ALDERLAKE_Q0) acpi_dp_add_integer(dsd, "is_es", 1); else acpi_dp_add_integer(dsd, "is_es", 0);