Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45443 )
Change subject: arch/x86/smbios: Update SMBIOS type 4 socket designation ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45443/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/45443/2/src/arch/x86/smbios.c@570 PS2, Line 570: "CPU%x" This will always write `CPU0`. Is it intended?
If `cnt` were static (in which case it should have a longer/clearer name), this would print CPU numbers in hex: CPU0, CPU1, CPU2, CPU3, CPU4, CPU5, CPU6, CPU7, CPU8, CPU9, CPUa, CPUb, CPUc, CPUd, CPUe, CPUf, CPU10, CPU11...