Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33628 )
Change subject: arch-x86/smbios: use ALIGN_UP instead of ALIGN for better readability
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33628/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/33628/1/src/arch/x86/smbios.c@1153
PS1, Line 1153: ALIGN_UP
missing include <commonlib/helpers. […]
yeah, explicitly including that in this file would be a good idea. I'd suggest adding that in a separate round of patches on top of this series. do you want to do that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie723ebe80f8f627021151413cb43adce6c88a0dc
Gerrit-Change-Number: 33628
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 20 Jun 2019 16:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment